Remove redundant exception handling in AWS hook#54485
Conversation
After apache#54299, there was a bit of except handling left over that appears to be redundant. It looks functionally equivalent to not having the additional handling.
boring-cyborg
bot
added
area:providers
provider:amazon
ferruzzi
left a comment
ferruzzi
left a comment
There was a problem hiding this comment.
Unless I'm missing something here, I think this is correct, that appears to be redundant.
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
My bad, I thought I had added a log.exception there. I think that would be a better thing to do
|
@amoghrajesh I thought about it more and realized that there's a case where replacing |
|
Sounds good in that case! |
5 participants
After #54299, there was a bit of except handling left over that appears to be redundant. It looks functionally equivalent to not having the additional handling.
Another approach I was thinking about was to add a
log.exceptionin theexcept Exceptionblock and not actually raise the exception 🤔 I'm open to any of the 2 approaches^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.